Re: [i3] i3status patch to colorize ethernet output

  • From: Michael Stapelberg <michael+i3@xxxxxxxxxxxxx>
  • To: i3-discuss <i3-discuss@xxxxxxxxxxxxx>
  • Date: Sun, 14 Feb 2010 12:51:32 +0100

Hi Peter,

Thanks for your patch, I have merged it. By the way, the preferred format
for patches is the one which "git format-patch origin" spits out because
it contains the author’s name and commit date.

Excerpts from Peter Johnson's message of Sa Feb 13 22:30:23 +0100 2010:

Here's a patch to colorize the ethernet output for i3status. (Why are the
castings of printf() to void inconsistent? Which way is preferred?)
The castings were added when I used lint to check the source code, but
as far as I remember lint stopped working some time ago after some change
in our source so I did not make sure that every printf has its cast to
void. The best way would be to keep the casts.

Best regards,
Michael

Other related posts: