[yoshimi] Re: Change in LV2 location

  • From: Will Godfrey <willgodfrey@xxxxxxxxxxxxxxx>
  • To: yoshimi@xxxxxxxxxxxxx
  • Date: Sun, 22 Nov 2015 21:51:13 +0000

On Sun, 22 Nov 2015 20:57:03 +0000
Adam Huffman <bloch@xxxxxxxxxxxx> wrote:

On Sun, Nov 22, 2015 at 08:01:49PM +0000, Will Godfrey wrote:
On Sun, 22 Nov 2015 18:27:12 +0000
Adam Huffman <bloch@xxxxxxxxxxxx> wrote:


Hi Will,

Just to let you know that I needed to revert to the old setting for the
LV2 library location in CMakeLists.txt for Fedora.

Without that change, the LV2 library was installed in the wrong location
for x86_64 builds.

The patch I included is here:

http://pkgs.fedoraproject.org/cgit/yoshimi.git/diff/yoshimi-libdir.patch

Cheers,
Adam

Thanks Adam.

I swear I'm going to end up having nightmares about this :(
... or maybe I'll just swear!

However...
Today I just got a patch from Timo Gurr which appears to resolve the same
(or
related) issues. It's on sourceforge:
http://sourceforge.net/p/yoshimi/patches/8/

So now I don't know whether to apply his, yours or both!

The frustrating thing is that just about everything seems to work correctly
for
me on a range of debian systems.


Hi Will,

The intent behind the patches is certainly different.

There's currently no problem with the architecture independent data on
Fedora, in the RPM at least, and that's what Timo is concerned about
with Exherbo, which I confess I've never used.

My patch is specifically about the LV2 library location. If it causes
other people problems, then I'm happy to keep it just for the Fedora
RPMs, having at least done my duty and mentioned it upstream...

Cheers,
Adam

Aha! The thot plickens :)

He had actually applied his patch on top of yours, because he was working
against V1.3.5.2 - although that two releases ago. However that means both
combined works for him, and they work for me on Intel & AMD 64 bit machines, and
an elderly 32 bit AMD.

If that combination also works for you I think it means we've covered most of
the bases.

Although not yet released I've just put a bugfix version 1.3.7.1 up on both
github and sourceforge that includes these. Can you give it a try and let me
know what you find?

There are also a couple of quite obscure bug fixes in there.

--
Will J Godfrey
http://www.musically.me.uk
Say you have a poem and I have a tune.
Exchange them and we can both have a poem, a tune, and a song.
Yoshimi source code is available from either:
http://sourceforge.net/projects/yoshimi
Or: https://github.com/Yoshimi/yoshimi
Our list archive is at: https://www.freelists.org/archive/yoshimi
To post, email to yoshimi@xxxxxxxxxxxxx

Other related posts: