[yoshimi] Re: Little bug with real-time updates in Subsynth..?
- From: Kristian Amlie <kristian@xxxxxxxxxx>
- To: yoshimi@xxxxxxxxxxxxx, Frank Neumann <beachnase@xxxxxx>
- Date: Wed, 26 Feb 2020 16:09:17 +0100
On 25.02.2020 22:49, Frank Neumann wrote:
Hi Will and all,
while playing around with current yoshimi Git (commit 13b942b4e), and being
quite happy about the realtime updates of parameters while playing :-), I
noticed a little glitch:
I was playing the sound "67 Smooth" from the "Will_Godfrey_Collection" bank,
and was tinkering with the harmonics sliders while keeping some notes pressed
on the keyboard.
When pulling up one of the initially "silent" sliders (say, #6), its harmonics
become audible, but when I bring that slider down to 0 again, it doesn't go
back
to complete silence - a small rest of that harmonics band remains audible as
long as I keep the notes down.
Once I release and press a key again, the sound is correct.
I was having a quick dive into the source code now (SUBnoteUI.cpp) since I
was thinking some parameter calculation is "off-by-one", but printing out
the current value in the SUBnoteharmonic::cb_mag_i() function did not reveal
any obvious mistakes.
Maybe this is an issue of not correctly taking over the last value change?
No, this is almost certainly because of the live feedback feature. There
is some trickery there, because at the code level a zero slider is not
just silent, it is not even created inside the note struct. However, as
soon as you move it up, it creates the the corresponding filter, and
this is not removed from that note again, but just turned down. It
should really be silent when turned all the way to zero again.
I have some other fixes coming up anyway, so I can probably fix this one
rather quickly and include it in that batch. Reminds me that I should
check this condition for the ADnote Volume knob as well, because I
suspect I may have (re-)introduced a similar bug.
--
Kristian
Yoshimi source code is available from either:
https://sourceforge.net/projects/yoshimi
Or:
https://github.com/Yoshimi/yoshimi
Our list archive is at:
https://www.freelists.org/archive/yoshimi
To post, email to yoshimi@xxxxxxxxxxxxx
Other related posts: