[yoshimi] Re: The Pythia speaks
- From: Will Godfrey <willgodfrey@xxxxxxxxxxxxxxx>
- To: yoshimi@xxxxxxxxxxxxx
- Date: Thu, 28 Dec 2017 13:33:27 +0000
On Thu, 28 Dec 2017 08:04:52 +0100
David Adler <d.adler@xxxxxxxxx> wrote:
Something non-critical.
I loaded an older patch set (.xmz) via the -l flag and the dialogue
from commit 95d02662a, main.cpp, popped up printing:
Existing config older than V 1.5
Check settings, save and restart.
Naively following the instructions I opened the settings window,
found things to be looking fine there, clicked 'Save and Close',
restarted.
The dialogue still appeared.
What did the trick was saving the patch set and restarting.
So here it apparently was the pre 1.5 .xmz file's lack of
'Yoshimi-major/minor' tags that triggered the pop-up, config files
are up to date. Looking at the sources it didn't become clear to me
what other cases might trigger it. Depending on that, the msg could
perhaps be more general, like
Files older than V 1.5 found
Check and save settings, save opened file and restart.
or distinguish cases and print some expansions of
{Existing config,Opened {patch set,instrument}} older than V 1.5
{Check settings\, s,S}ave and restart.
See. I need you guys to catch the stuff I miss!
That shouldn't happen at all. It's only supposed to check the config file. All
file loads temporarily store their version number in the same place, so my best
guess (at the moment) is that in this *specific* situation the stored value is
being overwritten by the .xmz file before it is checked.
I've been meaning to look through the whole of the startup code - it's pretty
convoluted - and try to refine it a bit.
Enjoy your holiday, if any!
Thanks. I was well enough to take a walk today... in brilliant sunshine for a
change :)
--
Will J Godfrey
http://www.musically.me.uk
Say you have a poem and I have a tune.
Exchange them and we can both have a poem, a tune, and a song.
Yoshimi source code is available from either:
https://sourceforge.net/projects/yoshimi
Or:
https://github.com/Yoshimi/yoshimi
Our list archive is at:
https://www.freelists.org/archive/yoshimi
To post, email to yoshimi@xxxxxxxxxxxxx
Other related posts: