[yoshimi] Re: reference to 'lock' is ambiguous
- From: Will Godfrey <willgodfrey@xxxxxxxxxxxxxxx>
- To: yoshimi@xxxxxxxxxxxxx
- Date: Fri, 27 Oct 2017 15:53:00 +0100
On Fri, 27 Oct 2017 05:15:57 -0400
Chris Ahlstrom <ahlstromcj@xxxxxxxxx> wrote:
I ran cmake with "VERBOSE=1", and you do use the -Wall setting, but
you can get even more warnings with -Wextra and -pedantic. There's more
as well:
https://kristerw.blogspot.com/2017/09/useful-gcc-warning-options-not-enabled.html
Thank for that. I really must lock down warnings seeing I'm supposed to be
runing the show!
By the way, I see a metric ton of -D defines on the command line, including
the misspelled "-DPOLIPHONY=80". A header file would be a better place for
those, IMHO.
Hysterical Raisins!
Hands up those who remember original Zyn and the globals file you had to edit
by hand.
So, there was that and a sprinking of defines dotted around all the files. Cal
decided to gloop the lot into CMake so you had some chance of finding them - and
also eliminated one or two differently named equivalents. Since then I've
tended to put any new ones in the same place, and moved a few more there that
were tucked away in obscure places.
I've no particular preference as to where they go - just as long as they all go
in a common place that can easily be seen. If anyone feels strongly about it and
wants to move them, that's OK by me. However (you were waiting for that, weren't
you), don't forget that every file that uses them would also need to have the
globals file included.
I don't know what would happen if you missed any. I think in some cases it
migh be treated as a zero, which could be 'interesting'.
Finally, some of them are actually only used within CMake so don't try to move
those out!
Did I say 'finally'? Well, finally...
POLIPHONY
Yep. I know about that one.
NOETMACS any better :)
{cough}Yoshimi_Policies.txt{cough}
Oh, and it used to be 60. Twas me wot bumped it up to 80.
Hmm. I think that beer was a it stronger than I expected. Snooze before more
coding I think :D
--
Will J Godfrey
http://www.musically.me.uk
Say you have a poem and I have a tune.
Exchange them and we can both have a poem, a tune, and a song.
Yoshimi source code is available from either:
https://sourceforge.net/projects/yoshimi
Or:
https://github.com/Yoshimi/yoshimi
Our list archive is at:
https://www.freelists.org/archive/yoshimi
To post, email to yoshimi@xxxxxxxxxxxxx
Other related posts: