Re: [yoshimi-user] Patch to fix pitch problem in 0.062

  • From: Will J Godfrey <WillGodfrey@xxxxxxxxxxxxxxx>
  • To: yoshimi-user@xxxxxxxxxxxxxxxxxxxxx
  • Date: Fri, 24 Feb 2012 21:33:36 +0000

On Thu, 23 Feb 2012 10:49:48 -0800 (PST)
jimmy <wg2002a@xxxxxxxxx> wrote:

Attached is my patch, I think it should fix the "wrong-pitch" problem. Not
pretty, but let's get it to work first. I only tried with the "default"
instrument. Will try some other instruments later when I have time. Perhaps
other folks here can help checking it out with their ears, too.

The patch should apply to the current trunk 0.062 . If anyone want to try it
out, feel free to give feed back if you found any problems. If it works for
you, let us know, too.

Some notes:

1) The change in Config.cpp is a "must" have, try stripping that out and
the pitch problem would rear its ugly face.

2) The changes to the .fl files are needed to build with FLTK 1.3 on 32-bit
system.

3) I changed CMakeFiles.txt variable BuildForAMD_X86_64 to OFF. I think
folks on 32-bit system may not be aware of the "default". I myself ran to
this weird build wild-goose chase on some header files not found. While I
think on 64-bit system, if you build 32-bit binaries, it should still run
fine.

Of course, who ever putting the code in can decide selectively what they want
to do with the changes.

Jimmy

Haven't had a chance to look at this myself, and tomorrow I'm away for a week
or so - I'll try and catch up later!

--
Will J Godfrey
http://www.musically.me.uk
Say you have a poem and I have a tune.
Exchange them and we can both have a poem, a tune, and a song.



Other related posts: