Re: [yoshimi-user] minor bug, potential fix

  • From: Kristian Amlie <kristian@xxxxxxxxxx>
  • To: yoshimi-user@xxxxxxxxxxxxxxxxxxxxx
  • Date: Sun, 03 Mar 2013 18:42:42 +0100

On 02/27/13 22:38, Rob Couto wrote:

Hi all,

There's a problem with PADsynth in that the UI allows for selecting 12
notes per octave and 8 octaves, but in CMakeLists.txt, PAD_MAX_SAMPLES
is 64. I'll often max out the notes/octave to 12 to completely remove
the inevitable soundfont-like pitching artifacts that comes from
having a single sample belong to several nearby notes, and leave the
octaves at 6. That apparently creates the right number of samples (72)
but then when I close the program (or load a different param), yoshimi
segfaults or aborts. Changing CMakeLists.txt on line 252 to

add_definitions (-DPAD_MAX_SAMPLES=96)

to match the UI seemed appropriate. Allowing a straight 128 to match
MIDI possibilities and adjusting the UI and engine seems more
appropriate but I didn't get that far, as this already made it stop
crashing when I try to switch away from or even save an offending
item. Boy, that was easy. Hope you're having fun, too...

Sounds reasonable to me. I guess not many people will take advantage of the full 128 MIDI notes though, so 96 is probably enough.

--
Kristian


Other related posts:

  • » Re: [yoshimi-user] minor bug, potential fix - Kristian Amlie