[yoshimi] Re: 1.5.5 rc1
- From: Rob Couto <dbtx11@xxxxxxxxx>
- To: yoshimi@xxxxxxxxxxxxx
- Date: Sat, 9 Dec 2017 11:28:56 -0500
Hi again, all...
On 12/5/17, Jesper Lloyd <jpl.lloyd@xxxxxxxxx> wrote:
Looks like it's just a typo in the library inclusion list, where
${LIBDL_LINUX_LIBS} is written instead of ${LIBDL_LINUX}.
Right now (at least with cmake 3.5.1) the non-defined variable is simply
omitted without warning.
Nice catch. :) I guess that bug was a sleeper but you flushed it out.
I am sorry that it just seemed normal to me; cmake adds variables with
_LIBRARIES and _INCLUDE_DIRS suffixed to another symbol e.g. with
find_package, but find_library is simpler and it just uses the
variable you give it. Also I must have let _LIBS masquerade as
_LIBRARIES in my brain :(
Apparently it went unnoticed for this long because -ldl comes along
anyway inside someone else's ${FOO_LIBRARIES}, and it's not quite safe
to rely on that, and of course on FreeBSD it won't show up anywhere.
And apparently in that user's antiX setup, it doesn't yet.
--
Rob
Yoshimi source code is available from either:
https://sourceforge.net/projects/yoshimi
Or:
https://github.com/Yoshimi/yoshimi
Our list archive is at:
https://www.freelists.org/archive/yoshimi
To post, email to yoshimi@xxxxxxxxxxxxx
Other related posts: