[yoshimi] Re: Fw: [Yoshimi/yoshimi] Add checkbutton to double range of filter frequency tracking (#10)
- From: Jörn Eichler <joerneichler@xxxxxxx>
- To: yoshimi@xxxxxxxxxxxxx
- Date: Fri, 25 Nov 2016 18:19:31 +0100
Am Freitag, 25. November 2016, 16:48:10 schrieb Will Godfrey:
Are PRs on github OK?
Yes, no problem, but it might be an idea to mention them here anyway. There
are quite a few people that like to mess about with {cough} evaluate
{cough} new ideas.
I see. I'll do that.
Don't worry about the Gui layout. That one's due for a tidy up anyway. I've
become fairly good at packing elephants into suitcases.
;-)
I've only had time for a quick look at the code - I'm a bit busy at present
:) Do you know what the tracking resolution works out at? presumably it
will be half that of the unmodified version, so I'm wondering if that has
overall pitch accuracy implications.
Right, the resolution would be half.
I'm not sure I completely understand your question about pitch accuracy but I
don't think there should be any problems:
The one modification, that actually changes the synth's output is in
FilterParams::getfreqtracking() were I changed the denominator from 64 to 32
when the new button is checked.
if (Pdoublefreqtrack != 0) {
return logf(notefreq / 440.0f) * (Pfreqtrack - 64.0f) / (32.0f * LOG_2);
} else {
return logf(notefreq / 440.0f) * (Pfreqtrack - 64.0f) / (64.0f * LOG_2);
}
So as long as the button is not checked the code, that's used (else branch),
is exactly the same as now, and since I did not touch any of the frequency
calculations, I'd also not expect any impact on pitch accuracy if the button
is checked.
Yoshimi source code is available from either:
http://sourceforge.net/projects/yoshimi
Or:
https://github.com/Yoshimi/yoshimi
Our list archive is at:
https://www.freelists.org/archive/yoshimi
To post, email to yoshimi@xxxxxxxxxxxxx
Other related posts: