Re: [yoshimi-user] suggested patch

  • From: Brendan Jones <brendan.jones.it@xxxxxxxxx>
  • To: yoshimi-user@xxxxxxxxxxxxxxxxxxxxx
  • Date: Sat, 04 Feb 2012 13:46:24 +0100

On 02/04/2012 01:12 PM, Kristian Amlie wrote:

On 02/04/12 00:17, Brendan Jones wrote:
OK, here's a suggested patch for the window title. For example:

# window title = "Synth 1", using name tag parameter
yoshimi -N "Synth 1"&

# window title = "Yoshimi: params-x"
# this is the existing behaviour using the load parameters flag
yoshimi -l /mnt/yoshimi/params-x.xmz&

# window title = "Synth 1: params-x", using both
yoshimi -N "Synth 1" -l /mnt/yoshimi/params-x.xmz&

Let me know if this is OK.

The patch works great on my system, and the code looks alright to my
eyes. Just one question though: With the current patch, you remove the
Yoshimi name entirely. It would be better to still keep "Yoshimi" as a
prefix, and add the name tag after it, no? Otherwise you can't see which
program it is at all in the task bar.


Thanks for the testing.

I was thinking that the "Yoshimi" text was a little redundant. With many windows open you would start the name tag text would become obscured. I think this is especially important in live situations where screen real estate may be scarce. You could always include it in the name-tag parameter? Interested to hear what others think!

I also noticed that the desktop icon is not being set in the title bar - adding this may make identified the app easier, but we would probabyy then want to do it to all the windows...

Brendan


Other related posts:

  1. Home
  2. yoshimi
  3. Archive
  4. 02-2012