Re: [yoshimi-user] suggested patch

  • From: Kristian Amlie <kristian@xxxxxxxxxx>
  • To: yoshimi-user@xxxxxxxxxxxxxxxxxxxxx
  • Date: Sat, 04 Feb 2012 14:32:57 +0100

On 02/04/12 13:46, Brendan Jones wrote:

On 02/04/2012 01:12 PM, Kristian Amlie wrote:
On 02/04/12 00:17, Brendan Jones wrote:
OK, here's a suggested patch for the window title. For example:

# window title = "Synth 1", using name tag parameter
yoshimi -N "Synth 1"&

# window title = "Yoshimi: params-x"
# this is the existing behaviour using the load parameters flag
yoshimi -l /mnt/yoshimi/params-x.xmz&

# window title = "Synth 1: params-x", using both
yoshimi -N "Synth 1" -l /mnt/yoshimi/params-x.xmz&

Let me know if this is OK.

The patch works great on my system, and the code looks alright to my
eyes. Just one question though: With the current patch, you remove the
Yoshimi name entirely. It would be better to still keep "Yoshimi" as a
prefix, and add the name tag after it, no? Otherwise you can't see which
program it is at all in the task bar.


Thanks for the testing.

I was thinking that the "Yoshimi" text was a little redundant. With many
windows open you would start the name tag text would become obscured. I
think this is especially important in live situations where screen real
estate may be scarce. You could always include it in the name-tag
parameter? Interested to hear what others think!

Yes, I see your point. The only snag then is that the name displayed in
qjackctl is different from the one in the title bar. If you include
yoshimi in the name tag, qjackctl will read "Yoshimi-yoshimi", while the
window title reads just "yoshimi". On the other hand, it's not such a
big deal. I'd be interested in hearing other opinions as well.

--
Kristian


I also noticed that the desktop icon is not being set in the title bar -
adding this may make identified the app easier, but we would probabyy
then want to do it to all the windows...

Brendan

------------------------------------------------------------------------------
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
_______________________________________________
yoshimi-user mailing list
yoshimi-user@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/yoshimi-user



Other related posts: